linux-kernel - Re: [ath5k-devel] Bugs on aspire one A150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <491DCA12.3000304@gmail.com>
Date:	Fri, 14 Nov 2008 20:57:22 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Bob Copeland <me@...copeland.com>
CC:	Nick Kossifidis <mickflemm@...il.com>, ath5k-devel@...ts.ath5k.org,
	linux-kernel@...r.kernel.org
Subject: Re: [ath5k-devel] Bugs on aspire one A150

Bob Copeland wrote:
> On Wed, Nov 12, 2008 at 07:51:47PM +0200, Maxim Levitsky wrote:
>>>> Why it doesn't accept new mac?, can this be fixed?
>> Any update on mac changer status?
> 
> As a first stab, can you try this patch?  This sets the address on
> add_interface and clears it on remove_interface, instead of only doing
> it at probe time.  I only compile-tested it.
> 
> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index 5ef8cc4..6c56893 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -2765,6 +2765,7 @@ static int ath5k_add_interface(struct ieee80211_hw *hw,
>  	/* Set to a reasonable value. Note that this will
>  	 * be set to mac80211's value at ath5k_config(). */
>  	sc->bintval = 1000;
> +	ath5k_hw_set_lladdr(sc->ah, conf->mac_addr);
>  
>  	ret = 0;
>  end:
> @@ -2777,11 +2778,13 @@ ath5k_remove_interface(struct ieee80211_hw *hw,
>  			struct ieee80211_if_init_conf *conf)
>  {
>  	struct ath5k_softc *sc = hw->priv;
> +	u8 mac[ETH_ALEN] = {};
>  
>  	mutex_lock(&sc->lock);
>  	if (sc->vif != conf->vif)
>  		goto end;
>  
> +	ath5k_hw_set_lladdr(sc->ah, mac);
>  	sc->vif = NULL;
>  end:
>  	mutex_unlock(&sc->lock);
> 

Works almost perfectly,

when I load the module, then run macchanger, and then ifconfig wlan0 up
then it works, if I do an ifconfig up once, then ifdowning the interface, it doesn't.

my iwl3945 allows me to

ifconfig wlan0 down
macchanger ....
ifconfig wlan0 up

The noise floor calibration issue bites me again and gain.
When it shows up, usually card continues to work, but at next assotiation stops working.
Maybe this is unrelated, don't know.
Reboot doesn't help, only a cold reboot/suspend to ram helps.
(Module reload doesn't help too).

Transfer speeds are unusually low:
Currently I compile kernel on main laptop, and copy files over nfs to aspire one.
Copying takes ages, and transfer speeds are at 200 Kbytes/s.
(AP isn't involved in direct transfers between stations, right?)

Both notebooks are in same room.

Also noticed, that continued transfer of large volumes (like the above) triggers
noise calibration time-outs, and when it does transfer speeds drop to 50Kbytes/s
Next assotiation usually fails, and only on/off cycle fixes this.

Best regards, and big thanks for help,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/