linux-kernel - Re: [GIT PATCH] USB patches for 2.6-git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Nov 2008 11:15:45 -0800
From:	Greg KH <greg@...ah.com>
To:	"Gupta, Ajay Kumar" <ajay.gupta@...com>
Cc:	Greg KH <gregkh@...e.de>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Felipe Balbi <felipe.balbi@...ia.com>,
	Sergei Shtylyov <sshtylyov@...mvista.com>
Subject: Re: [GIT PATCH] USB patches for 2.6-git

On Fri, Nov 14, 2008 at 09:36:03AM +0530, Gupta, Ajay Kumar wrote:
> Hi Greg,
> 
> There is a difference in the musb patch I submitted and the one which actually has been
> forwarded to you by Felipe. This difference has introduced a bug.
> 
> The patch in you series is,
> usb: musb: fix BULK request on different available endpoints
> 
> 
> It was submitted by me at,
> http://marc.info/?l=linux-usb&m=122337227617797&w=2
> 
> 
> And the one which is forwarded to you by Felipe is at,
> http://marc.info/?l=linux-usb&m=122528597316728&w=2
> 
> 
> There is a difference in between above two as below.
> Original: +	if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
> Sent to you: +	if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
> 
> It should be [best_end < 0].
> 
> If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/