linux-kernel - Re: [GIT PATCH] USB patches for 2.6-git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Nov 2008 23:10:32 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Greg KH <greg@...ah.com>
Cc:	"Gupta, Ajay Kumar" <ajay.gupta@...com>, Greg KH <gregkh@...e.de>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Felipe Balbi <felipe.balbi@...ia.com>
Subject: Re: [GIT PATCH] USB patches for 2.6-git

Greg KH wrote:

>>>>There is a difference in the musb patch I submitted and the one which 
>>>>actually has been
>>>>forwarded to you by Felipe. This difference has introduced a bug.

>>>>The patch in you series is,
>>>>usb: musb: fix BULK request on different available endpoints

>>>>It was submitted by me at,
>>>>http://marc.info/?l=linux-usb&m=122337227617797&w=2

>>>>And the one which is forwarded to you by Felipe is at,
>>>>http://marc.info/?l=linux-usb&m=122528597316728&w=2

>>>>There is a difference in between above two as below.
>>>>Original: +	if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
>>>>Sent to you: +	if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

>>>>It should be [best_end < 0].

>>>>If it is possible then please correct this mismatch in your series.

>>>I'll wait to get a patch from Felipe for this.

>>   I'm seeing it being to you sent at least a week ago -- look for "usb: 
>>musb: fix bug in musb_schedule".

> As Felipe is the maintainer of the musb code, and has been batching up
> patches and sending them on to me when needed, I have only been taking
> them from him.

> So that message is long deleted from my mail, sorry.

    Even though it was a message from him CCing you? :-)
    Here it is: http://marc.info/?l=linux-usb&m=122605639520312.

> thanks,
> greg k-h

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/