linux-kernel - drivers/video/backlight/mbp_nvidia_bl.c:114: error: storage size of '__mod_dmi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081114234131.GA28559@x200.localdomain>
Date:	Sat, 15 Nov 2008 02:41:31 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	dwmw2@...radead.org
Cc:	linux-kernel@...r.kernel.org
Subject: drivers/video/backlight/mbp_nvidia_bl.c:114: error: storage size
	of '__mod_dmi_device_table' isn't known

How can this work, given that MODULE_DEVICE_TABLE line expands into

	extern const struct dmi_device_id __mod_dmi_device_table __attribute__ ((unused, alias("mbp_device_table")));
				^^^^^^
but there is no struct dmi_device_id, there is struct dmi_system_id?

commit 239cfbde1f5843c4a24199f117d5f67f637d72d5
Author: David Woodhouse <dwmw2@...radead.org>
Date:   Tue Sep 16 16:25:24 2008 -0700

    Fix autoloading of MacBook Pro backlight driver.
    
    Use new MODULE_DEVICE_TABLE(dmi, ...) facility. There's no need for
    every driver to screw it up for themselves, when the alias can be
    generated automatically.
    
    Signed-off-by: David Woodhouse <David.Woodhouse@...el.com>

diff --git a/drivers/video/backlight/mbp_nvidia_bl.c b/drivers/video/backlight/mbp_nvidia_bl.c
index 385cba4..06964af 100644
--- a/drivers/video/backlight/mbp_nvidia_bl.c
+++ b/drivers/video/backlight/mbp_nvidia_bl.c
@@ -111,6 +111,4 @@ module_exit(mbp_exit);
 MODULE_AUTHOR("Matthew Garrett <mjg@...hat.com>");
 MODULE_DESCRIPTION("Nvidia-based Macbook Pro Backlight Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("svnAppleInc.:pnMacBookPro3,1");
-MODULE_ALIAS("svnAppleInc.:pnMacBookPro3,2");
-MODULE_ALIAS("svnAppleInc.:pnMacBookPro4,1");
+MODULE_DEVICE_TABLE(dmi, mbp_device_table);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/