linux-kernel - Re: [PATCH] pcmcia: ensure correct logging in do_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200811151624.24904.elendil@planet.nl>
Date:	Sat, 15 Nov 2008 16:24:24 +0100
From:	Frans Pop <elendil@...net.nl>
To:	dbrownell@...rs.sourceforge.net
Cc:	linux-kernel@...r.kernel.org, linux-pcmcia@...ts.infradead.org
Subject: Re: [PATCH] pcmcia: ensure correct logging in do_io_probe [v2]

On Sunday 09 November 2008, Dominik Brodowski wrote:
> On Fri, Nov 07, 2008 at 03:22:42PM +0100, Frans Pop wrote:
> > During early probing of the parent PCI bridge I/O window no socket
> > has been allocated yet.
> > In that case print &s->cb_dev->dev instead of &s->dev as device.
>
> similar to the other patch, this won't work: &skt->cb_dev is only
> available and set if the parent device is a PCI device; therefore,
> &skt->dev is the only thing we can use.

OK.

I still feel I'm missing something in the debug logging. Shouldn't there 
be a line saying something like the following?
yenta_cardbus 0000:02:06.0: Assigned pcmcia socket 0

> An alternative approach would be to move this initialization code only
> after we've set dev_name. Could you test whether this approach works
> for you, please?

Tested on two different systems: Toshiba Satellite A40 running i386 (with 
atheros wlan card already inserted during boot) and HP 2510p running 
x86_64 (with same card inserted after boot).
Both with patch applied against current mainline git. I've not seen any 
problems and wireless worked in both cases.

There are some differences in the logs (see attachments). I only see the 
IO probes on the Toshiba, not on the HP. I'd guess that's expected.

Tested-by: Frans Pop <elendil@...net.nl>

This does leave one minor issue from my previous patch. Please consider 
applying the attached patch.

Cheers,
FJP

View attachment "pcmcia_close-prink.patch" of type "text/x-diff" (665 bytes)

View attachment "pcmcia_hp2510p.log" of type "text/x-log" (591 bytes)

View attachment "pcmcia_toshiba.log" of type "text/x-log" (924 bytes)