linux-kernel - Re: [PATCH 3/4] tracing/branch-tracer: Fix a trace recursion on branch tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530811160601j1f1fb09cy7a1ad63b373b85b3@mail.gmail.com>
Date:	Sun, 16 Nov 2008 15:01:24 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Steven Rostedt" <rostedt@...dmis.org>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	"Jonathan Corbet" <corbet@....net>
Subject: Re: [PATCH 3/4] tracing/branch-tracer: Fix a trace recursion on branch tracer

2008/11/16 Ingo Molnar <mingo@...e.hu>:
> Regarding the "Impact" line, it's cool that you started adding them.
> I'd like to ask you to tweak them a little bit in the future: please
> try to describe the "practical impact" via them - not just a
> repetition of the source code change that the patch does.
>
> For example, for this patch, instead of this impact-line:
>
>  Impact: Make the branch tracer use raw irq save/restore
>
> a better one is:
>
>  Impact: fix crash when enabling the branch-tracer
>
> (i changed it in this patch, no need to resubmit. And it's not well
> documented anyway.)
>
> Thanks,


Ok. Yeah I had some trouble with this "impact" tag, finding it hard to
not overlap its message with this of the patch's subject but I better
understand now...
Perhaps this tag should be explained in
Documentation/development-process/5.Posting and SubmittingPatches...
(cc-ed Jonathan for the development-process documents)....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/