| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081116223013.GB2977@sortiz.org> Date: Sun, 16 Nov 2008 23:30:14 +0100 From: Samuel Ortiz <sameo@...nedhand.com> To: Mark Brown <broonie@...ena.org.uk> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 2.6.28] mfd: Correct WM8350 I2C return code usage On Wed, Nov 12, 2008 at 11:43:31PM +0000, Mark Brown wrote: > > With this patch you're breaking that expectation because the read|write_dev() > > I'd prefer to fix the callers code, so that we keep the expected semantics > > Just to clarify, when you say "expectation" and "fix" are you talking > about your preference that the hardware access functions return the > number of bytes read or written or is there something else going on > here? No, definitely just my preference. I personnaly expect this kind of IO routines to return the number of bytes read/written. > To be honest I'm really not sure it's worth changing this - I'm having a > hard time thinking of a user that would be able to do anything useful > with a short access. I agree with that, yes. > It also seems like it'd be a rather invasive > change for an -rc. Fair enough, I applied your patch, and sent Linus a pull request. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists