linux-kernel - Re: [PATCH] Fix kunmap() argument in sg_miter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081117082201.GB24603@elte.hu>
Date:	Mon, 17 Nov 2008 09:22:01 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Tejun Heo <htejun@...il.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Hugh Dickins <hugh@...itas.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] Fix kunmap() argument in sg_miter_stop


* Jens Axboe <jens.axboe@...cle.com> wrote:

> +#define kunmap(p)			\
> +	do {				\
> +		struct page *__p;	\
> +		(void) (&__p == &(p));	\
> +		__kunmap(p);		\
> +	} while (0)
> +
> +#define kunmap_atomic(a, t)		\
> +	do {				\
> +		void *__p;		\
> +		(void) (&__p == &(a));	\
> +		__kunmap_atomic(a, t);	\
> +	} while (0)

Agreed - but please use the typecheck() primitive. (linux/typecheck.h)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/