linux-kernel - Re: [PATCH 1/7] mm: introduce simple_malloc()/simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49212A23.3000209@linux.vnet.ibm.com>
Date:	Mon, 17 Nov 2008 13:54:03 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	David Miller <davem@...emloft.net>
CC:	akpm@...ux-foundation.org, kosaki.motohiro@...fujitsu.com,
	kamezawa.hiroyu@...fujitsu.com, laijs@...fujitsu.com,
	arjan@...radead.org, airlied@...il.com, menage@...gle.com,
	jens.axboe@...cle.com, jack@...e.cz, jes@....com,
	linux-kernel@...r.kernel.org, dada1@...mosbay.com,
	adobriyan@...il.com
Subject: Re: [PATCH 1/7] mm: introduce simple_malloc()/simple_free()

David Miller wrote:
> From: Andrew Morton <akpm@...ux-foundation.org>
> Date: Sun, 16 Nov 2008 23:13:01 -0800
> 
>> In fact it's not immediately clear why __vmalloc() takes a gfp_t
>> argument either?
> 
> Probably for things like GFP_DMA32, GFP_HIGHMEM, et al.
> 

vmalloc() hides away GFP_DMA32 and hard codes gfp_mask to GFP_KERNEL |
__GFP_HIGHMEM. __vmalloc() lies like Andrew mentioned. For the use cases
mentioned in this thread, we don't really care about GFP_DMA32 (or do we?).

I would prefer to avoid passing the gfp_mask and call the API something like
blocking_vkmalloc() and blocking_vkzalloc() or something better.

-- 
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/