linux-kernel - Re: [PATCH] leds: Add WM8350 LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081117115709.GF1559@sirena.org.uk>
Date:	Mon, 17 Nov 2008 11:57:09 +0000
From:	Mark Brown <broonie@...ena.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	rpurdie@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: Add WM8350 LED driver

On Fri, Nov 14, 2008 at 03:19:08PM -0800, Andrew Morton wrote:

> > +	led_classdev_unregister(&led->cdev);
> > +	schedule_work(&led->work);
> > +	flush_scheduled_work();

> The schedule_work() is unexpected and I can't immediately see why it's
> here.  If it is indeed correct, I'd suggest the addition of a comment.

Me either, I'll remove it and fix the other things you raised too.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/