linux-kernel - Re: [PATCH] ipc: do not goto to the next line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081117152302.GC14976@hack.voiplan.pt>
Date:	Mon, 17 Nov 2008 15:23:02 +0000
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	"Denis V. Lunev" <den@...nvz.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipc: do not goto to the next line

On Mon, Nov 17, 2008 at 06:10:52PM +0300, Denis V. Lunev wrote:
>Signed-off-by: Denis V. Lunev <den@...nvz.org>
>---
> ipc/sem.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/ipc/sem.c b/ipc/sem.c
>index 0821224..b91d455 100644
>--- a/ipc/sem.c
>+++ b/ipc/sem.c
>@@ -1216,7 +1216,6 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
> 	if (timeout && jiffies_left == 0)
> 		error = -EAGAIN;
> 	list_del(&queue.list);
>-	goto out_unlock_free;
> 
> out_unlock_free:
> 	sem_unlock(sma);

Aha, this goto is obviously useless. :)

If you need, 
Reviewed-by: WANG Cong <wangcong@...ux.org>


-- 
"Sometimes the only way to stay sane is to go a little crazy."

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/