linux-kernel - Re: [PATCH 2/3] account_steal_time: kill the unneeded account_group_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081117155425.GB12081@elte.hu>
Date:	Mon, 17 Nov 2008 16:54:25 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Roland McGrath <roland@...hat.com>,
	Doug Chapman <doug.chapman@...com>,
	Frank Mayhar <fmayhar@...gle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] account_steal_time: kill the unneeded
	account_group_system_time()


* Oleg Nesterov <oleg@...hat.com> wrote:

> I don't actually understand account_steal_time() and I failed to find the
> commit which added account_group_system_time(), but this looks bogus.
> In any case rq->idle must be single-threaded, so it can't have ->totals.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> 
> --- K-28/kernel/sched.c~ACCT_STEAL_KILL_GACCT	2008-11-10 13:05:09.000000000 +0100
> +++ K-28/kernel/sched.c	2008-11-16 23:40:05.000000000 +0100
> @@ -4198,7 +4198,6 @@ void account_steal_time(struct task_stru
>  
>  	if (p == rq->idle) {
>  		p->stime = cputime_add(p->stime, steal);
> -		account_group_system_time(p, steal);
>  		if (atomic_read(&rq->nr_iowait) > 0)
>  			cpustat->iowait = cputime64_add(cpustat->iowait, tmp);

could be a typo - is there no similar construct nearby?

Makes sense in any case, applied to tip/core/signal - thanks Oleg.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/