linux-kernel - Re: [patch 2.6.28-rc5] regulator: enable/disable refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1226940390.585.4.camel@vega.slimlogic.co.uk>
Date:	Mon, 17 Nov 2008 16:46:30 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	dbrownell@...rs.sourceforge.net
Cc:	Mark Brown <broonie@...ena.org.uk>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2.6.28-rc5] regulator: enable/disable refcounting

On Mon, 2008-11-17 at 08:21 -0800, David Brownell wrote:
> On Monday 17 November 2008, Mark Brown wrote:
> > On Sun, Nov 16, 2008 at 11:44:46AM -0800, David Brownell wrote:
> > 
> > > +	mutex_lock(&rdev->mutex);
> > > +	if (regulator->enabled == 1) {
> > > +		ret = _regulator_disable(rdev);
> > > +		if (ret == 0)
> > > +			regulator->uA_load = 0;
> > 
> > Why clear the load here?  I'd expect to be able to enable and disable
> > the regulator while preserving the configuration.
> 
> That clear was in the original code.  Didn't make much sense
> to me either, but I was just caring it forward...
> 

Hmm, this looks like a bug - I'll fix in a subsequent patch.

Will have time to look over the rest later tonight.

Thanks

Liam 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/