linux-kernel - Re: [PATCH 1/5] x86: ia32_signal: cleanup macro COPY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4921B084.4070100@ct.jp.nec.com>
Date:	Mon, 17 Nov 2008 09:57:24 -0800
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] x86: ia32_signal: cleanup macro COPY

Américo Wang wrote:
> On Sat, Nov 15, 2008 at 3:24 AM, Hiroshi Shimamoto
> <h-shimamoto@...jp.nec.com> wrote:
>> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>>
>> Impact: cleanup
>>
>> No need to use temporary variable in this case.
>>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>> ---
>>  arch/x86/ia32/ia32_signal.c |    6 ++----
>>  1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
>> index e886907..a28790a 100644
>> --- a/arch/x86/ia32/ia32_signal.c
>> +++ b/arch/x86/ia32/ia32_signal.c
>> @@ -197,10 +197,8 @@ struct rt_sigframe
>>        /* fp state follows here */
>>  };
>>
>> -#define COPY(x)                {               \
>> -       unsigned int reg;               \
>> -       err |= __get_user(reg, &sc->x); \
>> -       regs->x = reg;                  \
>> +#define COPY(x)                        {               \
>> +       err |= __get_user(regs->x, &sc->x);     \
>>  }

Thanks for reviewing this!

> 
> Then you can also kill the braces now. :)

I guess, checkpatch will complain. Personally I don't care.

> 
> What's more, if I saw it correctly, the belowing two __get_user() calls can
> also be replaced by COPY().

I'm sorry, I cannot catch about this. Which __get_user()?

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/