linux-kernel - Re: [PATCH 2/4] integrity: Linux Integrity Module(LIM)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1226948980.2927.33.camel@localhost.localdomain>
Date:	Mon, 17 Nov 2008 14:09:40 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	James Morris <jmorris@...ei.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	David Safford <safford@...son.ibm.com>,
	Serge Hallyn <serue@...ux.vnet.ibm.com>,
	Mimi Zohar <zohar@...ibm.com>
Subject: Re: [PATCH 2/4] integrity: Linux Integrity Module(LIM)

On Mon, 2008-11-17 at 11:05 -0500, Christoph Hellwig wrote: 
> On Wed, Nov 12, 2008 at 10:47:12PM -0500, Mimi Zohar wrote:
> > This version resolves the merge issues resulting from the removal
> > of the nameidata parameter to inode_permission(), by moving the
> > integrity_inode_permission() call from inode_permission() to
> > may_open(), and renaming the hook to integrity_nameidata_check().
> 
> Still neither a good parameter nor a good name.  If you look at fsdevel
> you'll see that a patch for the next merged window is already out and
> in Al's to be applied queue that removes the nameidata there.  A
> strcut path and maybe the MAY_ lookup flags should be enough for you,
> and a integrity_path_check also sounds like it really does what you
> want.

Ok. So, instead of integrity_nameidata_check(nd, flags), call it
integrity_path_check(path, flags). 

Perhaps I'm looking at the wrong vfs tree, but I don't see the changes.
Where is fsdevel? 

> Also please merge the last radix tree patch into this one so tat it's
> possible to review the code that actually goes in instead of replacing
> a large part of it in a follow-up patch.

np

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/