linux-kernel - 2.6.28-rc5: unused variable in pagetable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Nov 2008 06:53:12 +0300
From:	Andrey Borzenkov <arvidjaar@...l.ru>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: 2.6.28-rc5: unused variable in pagetable_init

  CC      arch/x86/mm/init_32.o
/home/bor/src/linux-git/arch/x86/mm/init_32.c: In function ‘pagetable_init’:
/home/bor/src/linux-git/arch/x86/mm/init_32.c:515: warning: unused variable ‘pgd_base’

Well, pagetable_init is noop unless HIGHMEM is defined so it could be
as simple as that.

Or is something else expected to go into pagetable_init for more general
case?

--- arch/x86/mm/init_32.c       2008-11-10 06:19:14.000000000 +0300
+++ /tmp/init_32.c      2008-11-17 06:52:21.383685722 +0300
@@ -435,9 +435,17 @@ static void __init set_highmem_pages_ini
 }
 #endif /* !CONFIG_NUMA */

+static void __init pagetable_init(void)
+{
+       pgd_t *pgd_base = swapper_pg_dir;
+
+       permanent_kmaps_init(pgd_base);
+}
+
 #else
 # define permanent_kmaps_init(pgd_base)                do { } while (0)
 # define set_highmem_pages_init()      do { } while (0)
+# define pagetable_init()      do { } while (0)
 #endif /* CONFIG_HIGHMEM */

 void __init native_pagetable_setup_start(pgd_t *base)
@@ -510,13 +518,6 @@ static void __init early_ioremap_page_ta
        early_ioremap_reset();
 }

-static void __init pagetable_init(void)
-{
-       pgd_t *pgd_base = swapper_pg_dir;
-
-       permanent_kmaps_init(pgd_base);
-}
-
 #ifdef CONFIG_ACPI_SLEEP
 /*
  * ACPI suspend needs this for resume, because things like the intel-agp

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)