linux-kernel - Re: [PATCH] leds: Fix locking for WM8350

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081117230522.GA29916@sirena.org.uk>
Date:	Mon, 17 Nov 2008 23:05:24 +0000
From:	Mark Brown <broonie@...ena.org.uk>
To:	Richard Purdie <rpurdie@...ys.net>
Cc:	Pavel Machek <pavel@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: Fix locking for WM8350

On Mon, Nov 17, 2008 at 03:33:15PM +0000, Richard Purdie wrote:

> I've not looked in detail at the code but it looks like a maximum of a
> 32 bit value where you don't actually care which write succeeds as long
> as it takes one of the values written? I don't see why that particular

Pretty much (it's an enum led_brightness) - it's just a standard LED
that can't be written without taking interrupts along the lines of the
GPIO LED driver.

> variable needs any locking or to be atomic?

I'd certainly be surprised if it were an issue in any practical system.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/