linux-kernel - Re: [PATCH] USB/ISP1760: Add support for the generic platfrom device centralized driver model (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49229E59.8040306@linutronix.de>
Date:	Tue, 18 Nov 2008 11:52:09 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Bryan Wu <cooloney@...nel.org>
CC:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH] USB/ISP1760: Add support for the generic platfrom device
 centralized driver model (v2)

Bryan Wu wrote:
> From: Michael Hennerich <michael.hennerich@...log.com>
> 
> v2-v1:
>  - cleanup style issue
>  - add Kconfig option CONFIG_USB_ISP1760_PDEV
>  - isp1760 interrupt is default setup TRIGGER_LOW
Trigger low should be fine.

> 
> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>
> ---
>  drivers/usb/host/Kconfig      |    6 +++
>  drivers/usb/host/isp1760-if.c |   95 +++++++++++++++++++++++++++++++++++++++++
>  include/linux/usb/isp1760.h   |   19 ++++++++
>  3 files changed, 120 insertions(+), 0 deletions(-)
>  create mode 100644 include/linux/usb/isp1760.h
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 427b3ac..1e38e8a 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -123,6 +123,12 @@ config USB_ISP1760_HCD
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called isp1760.
>  
> +config USB_ISP1760_PDEV
> +	bool "Support for the generic platfrom device driver model"
> +	depends on USB_ISP1760_HCD
> +	---help---
> +	  Enables support for the generic platfrom device centralized driver model
> +

This is probably a misunderstanding. In the previous email I was refering 
the patch [1] which removes the Kconfig entries and makes it 
unconditional. Since platform device are always available we can get rid 
of depend on PCI || OF in Kconfig and depend just on USB same like isp116x 
does. The patch I am refering to is mainline so this won't apply, sorry.
I'm fine with the other parts of the patch.

[1] http://marc.info/?l=linux-usb&m=122563596420156&w=2


Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/