linux-kernel - Re: [RFC,v2] x86_64: save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081118111633.GA21036@mailshack.com>
Date:	Tue, 18 Nov 2008 12:16:33 +0100
From:	Alexander van Heukelum <heukelum@...lshack.com>
To:	Jan Beulich <jbeulich@...ell.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <gcosta@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	"H. Peter Anvin" <hpa@...or.com>, heukelum@...tmail.fm
Subject: Re: [RFC,v2] x86_64: save_args out of line

On Tue, Nov 18, 2008 at 08:09:28AM +0000, Jan Beulich wrote:
> >>> Alexander van Heukelum <heukelum@...lshack.com> 17.11.08 18:52 >>>
> >The macro "interrupt" in entry_64.S generates a lot of code and it
> >is used more and more often. This patch moves most of its contents
> >into an external function. This saves anywhere between 500 and 2500
> >bytes of text depending on the configuration.
> 
> Without numbers, I'd doubt that the code size reduction outweighs the
> overhead of the extra call. Did you do any measurements?

I have not measured yet. I'll see if I can highjack a machine. What
kind of benchmark would you suggest?

> >Dwarf2-annotations are most probably wrong or missing at all.
> 
> Indeed - do you have intentions to address this?

Yes, I'ld like to get it right. What do you use to check the
annotations?

Greetings,
	Alexander

> Jan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/