linux-kernel - Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hej19dn9o.wl%tiwai@suse.de>
Date:	Tue, 18 Nov 2008 17:14:43 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Hannes Eder" <hannes@...neseder.net>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register

At Tue, 18 Nov 2008 16:59:03 +0100,
Hannes Eder wrote:
> 
> Do not ignore the return of 'device_create_file' in
> 'snd_card_register' and thereby fixing the following warnings:
> 
> sound/core/init.c: In function 'snd_card_register':
> sound/core/init.c:640: warning: ignoring return value of
> 'device_create_file', declared with attribute warn_unused_result
> sound/core/init.c:641: warning: ignoring return value of
> 'device_create_file', declared with attribute warn_unused_result

The changes look good, but please run checkpatch.pl to your patch and
fix the coding style issues suggested there.


thanks,

Takashi

> 
> Signed-off-by: Hannes Eder <hannes@...neseder.net>
> ---
>  sound/core/init.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/init.c b/sound/core/init.c
> index af1e407..814d834 100644
> --- a/sound/core/init.c
> +++ b/sound/core/init.c
> @@ -637,8 +637,10 @@ int snd_card_register(struct snd_card *card)
>  #endif
>  #ifndef CONFIG_SYSFS_DEPRECATED
>  	if (card->card_dev) {
> -		device_create_file(card->card_dev, &card_id_attrs);
> -		device_create_file(card->card_dev, &card_number_attrs);
> +		if ((err = device_create_file(card->card_dev, &card_id_attrs)) < 0)
> +			return err;
> +		if ((err = device_create_file(card->card_dev, &card_number_attrs)) < 0)
> +			return err;
>  	}
>  #endif
>  	return 0;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/