linux-kernel - Re: [PATCH 1/2] cdrom: split mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081118195429.GA6010@joi>
Date:	Tue, 18 Nov 2008 20:54:33 +0100
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] cdrom: split mmc_ioctl to lower stack usage

On Mon, Nov 17, 2008 at 01:11:34PM +0100, Jens Axboe wrote:
> On Sun, Nov 16 2008, Marcin Slusarz wrote:
> > Checkstack output:
> > 
> > Before:
> > mmc_ioctl:                  584
> > 
> > After:
> > mmc_ioctl_dvd_read_struct:  280
> > mmc_ioctl_cdrom_subchannel: 152
> > mmc_ioctl_cdrom_read_data:  120
> > mmc_ioctl_cdrom_volume:     104
> > mmc_ioctl_cdrom_read_audio: 104
> > (mmc_ioctl is inlined into cdrom_ioctl - 104 bytes)
> 
> Looks good (both 1 and 2). What kind of testing have you done? I have
> applied it to for-2.6.29.

Only very basic testing - I can play audio cd's via amarok (CDROMREADRAW)
and kscd (CDROMREADAUDIO).

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/