linux-kernel - Re: [PATCH] eCryptfs: Allocate up to two scatterlists for crypto ops on keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081118223100.GC6581@halcrowt61p.austin.ibm.com>
Date:	Tue, 18 Nov 2008 16:31:00 -0600
From:	Michael Halcrow <mhalcrow@...ibm.com>
To:	Leon Woestenberg <leon.woestenberg@...il.com>
Cc:	linux-kernel@...r.kernel.org, pjssilva@....usp.br,
	akpm@...ux-foundation.org, dustin.kirkland@...il.com,
	sandeen@...hat.com
Subject: Re: [PATCH] eCryptfs: Allocate up to two scatterlists for crypto
	ops on keys

On Fri, Nov 14, 2008 at 05:49:58PM +0100, Leon Woestenberg wrote:
> Hello,
> 
> On Fri, Nov 14, 2008 at 5:40 PM, Michael Halcrow <mhalcrow@...ibm.com> wrote:
> >
> > -       sg_init_table(&dst_sg, 1);
> > -       sg_init_table(&src_sg, 1);
> 
> Why did you remove the inits?

This initialization is done in virt_to_scatterlist() and is thus
redundant for this function.

> With self-checking enabled in the kernel, sg accessor functions will
> check on proper initialization and BUGON().
> 
> It might be your use-case would not hit this, as it seems not to use
> sg_ macro's much.
> 
> Regards,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/