linux-kernel - Re: [RFC,v2] x86_64: save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49235347.7010005@zytor.com>
Date:	Tue, 18 Nov 2008 15:44:07 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Andi Kleen <andi@...stfloor.org>,
	Roland McGrath <roland@...hat.com>,
	Ingo Molnar <mingo@...e.hu>, Jan Beulich <jbeulich@...ell.com>,
	heukelum@...tmail.fm, Thomas Gleixner <tglx@...utronix.de>,
	Alexander van Heukelum <heukelum@...lshack.com>,
	Glauber Costa <gcosta@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: [RFC,v2] x86_64: save_args out of line

Jeremy Fitzhardinge wrote:
> 
> Not really.  At the moment we have two parallel assembly languages which 
> say different things about the same instructions.  In practice, almost 
> nobody understands the cfi parts, so they just get ignored while the x86 
> instructions change around them, leaving them either stale or missing.
> 
> If we had a sensible macro layer which emits both instructions and cfi 
> annotations, it at least means that people who write plain x86 
> instructions will simply get no annotations, and people who bother to 
> learn the (clearly and fully documented) macros will get the best of both.
> 

I think that it would be nice to have macros for the most commonly 
annotatable instructions, e.g. push, and stack pointer movement.  Just 
compactifying the code should improve readability, if perhaps not 
writability.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/