linux-kernel - Re: [PATCH] fs/binfmt_misc.c: let binfmt status be more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081118163620.de14c1ec.akpm@linux-foundation.org>
Date:	Tue, 18 Nov 2008 16:36:20 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Qinghuang Feng <qhfeng.kernel@...il.com>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	linux-fsdevel@...r.kernel.org, qhfeng.kernel@...il.com
Subject: Re: [PATCH] fs/binfmt_misc.c: let binfmt status be more readable

On Mon, 17 Nov 2008 15:38:16 +0800
Qinghuang Feng <qhfeng.kernel@...il.com> wrote:

> The following is what it looks like before patching.
> It is not much readable.
> 
> user@...ntu:/proc/sys/fs/binfmt_misc$ cat status 
> enableduser@...ntu:/proc/sys/fs/binfmt_misc$
> 
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@...il.com>
> ---
> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
> index f2744ab..72e8b24 100644
> --- a/fs/binfmt_misc.c
> +++ b/fs/binfmt_misc.c
> @@ -652,7 +652,7 @@ static const struct file_operations bm_register_operations = {
>  static ssize_t
>  bm_status_read(struct file *file, char __user *buf, size_t nbytes, loff_t *ppos)
>  {
> -	char *s = enabled ? "enabled" : "disabled";
> +	char *s = enabled ? "enabled\n" : "disabled\n";
>  
>  	return simple_read_from_buffer(buf, nbytes, ppos, s, strlen(s));
>  }

Well.  That's a bugfix, really.

It fixes a bug which has been there for a very long time, in a way
which is non-backward-compatible.

Are there existing applications out there which will disastrously fail
if we add a newline to the /proc/sys/fs/binfmt_misc/status contents?  I
somehow doubt it.  But we shall find out :)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/