linux-kernel - RE: [PATCH] drivers/video/backlight/da903x.c: introduce one more missing kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E913911567467945BBEB9277E27868B0014E51CF@msiexch01.marvell.com>
Date:	Wed, 19 Nov 2008 00:55:14 -0800
From:	"Eric Miao" <ymiao3@...vell.com>
To:	"Mike Rapoport" <mike@...pulab.co.il>
Cc:	<akpm@...ux-foundation.org>, <rpurdie@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<rpurdie@...ux.intel.com>
Subject: RE: [PATCH] drivers/video/backlight/da903x.c: introduce one more missing kfree

Acked-by: Eric Miao <eric.miao@...vell.com>

Andrew,

Could you please help merge this as well? Thanks.

-----Original Message-----
From: Mike Rapoport [mailto:mike@...pulab.co.il] 
Sent: Wednesday, November 19, 2008 4:51 PM
Cc: rpurdie@...ux.intel.com; linux-kernel@...r.kernel.org;
kernel-janitors@...r.kernel.org; Eric Miao; Mike Rapoport;
rpurdie@...ux.intel.com
Subject: [PATCH] drivers/video/backlight/da903x.c: introduce one more
missing kfree

One more error handling code should have kfree as well

Signed-off-by: Mike Rapoport <mike@...pulab.co.il>
---
 drivers/video/backlight/da903x.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/backlight/da903x.c
b/drivers/video/backlight/da903x.c
index 75388b9..93bb434 100644
--- a/drivers/video/backlight/da903x.c
+++ b/drivers/video/backlight/da903x.c
@@ -131,6 +131,7 @@ static int da903x_backlight_probe(struct
platform_device *pdev)
 			data, &da903x_backlight_ops);
 	if (IS_ERR(bl)) {
 		dev_err(&pdev->dev, "failed to register backlight\n");
+		kfree(data);
 		return PTR_ERR(bl);
 	}
 
-- 
1.5.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/