linux-kernel - Re: [PATCH] kobject_add: use constant strings directly as fmt strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081119155736.GA5072@suse.de>
Date:	Wed, 19 Nov 2008 07:57:36 -0800
From:	Greg KH <gregkh@...e.de>
To:	crquan@...il.com
Cc:	Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kobject_add: use constant strings directly as fmt
	strings

On Wed, Nov 19, 2008 at 11:54:19PM +0800, crquan@...il.com wrote:
> From: Cheng Renquan <crquan@...il.com>
> 
> Signed-off-by: Cheng Renquan <crquan@...il.com>
> ---
>  block/blk-sysfs.c |    2 +-
>  block/elevator.c  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index 21e275d..0b189e9 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -342,7 +342,7 @@ int blk_register_queue(struct gendisk *disk)
>  		return 0;
>  
>  	ret = kobject_add(&q->kobj, kobject_get(&disk_to_dev(disk)->kobj),
> -			  "%s", "queue");
> +			  "queue");

Why?  What does this change buy us?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/