linux-kernel - Re: [PATCH] [WATCHDOG] [hpwdt] Set the mapped BIOS address space as executable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081120000215.45071a50@kopernikus.site>
Date:	Thu, 20 Nov 2008 00:02:15 +0100
From:	Bernhard Walle <bwalle@...e.de>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Mingarelli, Thomas" <Thomas.Mingarelli@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: Re: [PATCH] [WATCHDOG] [hpwdt] Set the mapped BIOS address space as
 executable

* Wim Van Sebroeck [2008-11-20 00:00]:
>
> Hi All,
> 
> > * Andrew Morton [2008-11-19 09:30]:
> > > > 
> > > 
> > > (top-posting repaired.  Please don't top-post!)
> > > 
> > > I haven't seen any patch which alters hpwdt_pretimeout() and there is
> > > no such patch in linux-next.  Perhaps it got lost?
> 
> This was the patch (see below). It's in the linux-2.6-watchdog-next tree now,
> so it should go into the linux-next tree soon.
> 
> The other patch is in the linux-2.6-watchdog-next tree also.

Wasn't the conclusion that NOTIFY_OK always works and we should not
rely on that 'allow_kdump' option?


Regards,
Bernhard


>  
>  static void __iomem *pci_mem_addr;		/* the PCI-memory address */
>  static unsigned long __iomem *hpwdt_timer_reg;
> @@ -485,7 +485,11 @@ static int hpwdt_pretimeout(struct notifier_block *nb, unsigned long ulReason,
>  			"Management Log for details.\n");
>  	}
>  
> -	return NOTIFY_STOP;
> +	/*
> +	 * for kdump, we must return NOTIFY_OK here to execute the
> +	 * crash_nmi_callback afterwards, see arch/x86/kernel/crash.c
> +	 */
> +	return allow_kdump ? NOTIFY_OK : NOTIFY_STOP;
>  }
>  
>  /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/