linux-kernel - Re: [PATCH] hid: Complete support for the new unibody macbooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Nov 2008 00:10:03 +0100
From:	Henrik Rydberg <rydberg@...omail.se>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: Complete support for the new unibody macbooks

Jiri Kosina wrote:
> On Wed, 19 Nov 2008, Henrik Rydberg wrote:
> 
>> Without the mouse ignore quirk, HID will find the "normal" usb mouse 
>> interface. The current situation is much worse than to throw the bcm5974 
>> patches in untested. And this is not even the case; the updated driver 
>> has been in use as a dkms package for almost a month.
> 
> Therefore my memory must have been wrong -- I thought that you told me 
> when I was merging f89bd95c5c that the devices are not standard HID 
> devices at all, and therefore they can be safely ignored by the driver 
> right away, as they can't be driven by HID driver anyway.

These usb devices provide several different functions through the same
interface. By default, it looks like a regular mouse interface, which
HID will claim. This is why we need the quirks.

> If this is not the case, I'll then revert the hid_mouse_ignore_list[] 
> addition peformed in a96d6ef34 and will push it for 2.6.29, so that it 
> goes in together with bcm5974 driver modifications.

Yes, I think that is best.

> Thanks and sorry if I messed this up,

No harm done. :-)

Thanks,
Henrik

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/