linux-kernel - Re: [PATCH 1/1] cpumask: smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200811201008.31978.rusty@rustcorp.com.au>
Date:	Thu, 20 Nov 2008 10:08:31 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	linux-kernel@...r.kernel.org, Mike Travis <travis@....com>,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com, npiggin@...e.de,
	axboe@...nel.dk
Subject: Re: [PATCH 1/1] cpumask: smp_call_function_many()

On Thursday 20 November 2008 06:53:27 Hiroshi Shimamoto wrote:
> Rusty Russell wrote:
> > +	/* Fastpath: do that cpu by itself. */
> > +	if (next_cpu >= nr_cpu_ids)
> > +		smp_call_function_single(cpu, func, info, wait);
>
> Hi Rusty,
>
> I think, return is needed here. If not func will be called twice.

Indeed, thanks!

Fixed,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/