linux-kernel - Re: default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4923B597.7090208@qualcomm.com>
Date:	Tue, 18 Nov 2008 22:43:35 -0800
From:	Max Krasnyansky <maxk@...lcomm.com>
To:	David Miller <davem@...emloft.net>
CC:	"galak@...nel.crashing.org" <galak@...nel.crashing.org>,
	"csnook@...hat.com" <csnook@...hat.com>,
	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>
Subject: Re: default IRQ affinity change in v2.6.27 (breaking several SMP
 PPC based systems)



David Miller wrote:
> From: Kumar Gala <galak@...nel.crashing.org>
> Date: Fri, 24 Oct 2008 10:39:05 -0500
> 
>> As for making it ARCH specific, that doesn't really help since not
>> all PPC hw has the limitation I spoke of.  Not even all MPIC (in our
>> cases) have the limitation.
> 
> Since the PPC code knows exactly which MPICs have the problem the
> PPC code is where the constraining can occur.
> 
> I agree completely with the suggestion that the arch code has to
> interpret the cpumask as appropriate for the hardware, since the
> user can stick "illegal" values there anyways.

Sorry for delay in replying to this. And sorry for causing regression on some
ppc platforms.
I totally agree with what Dave said above. ALL_CPUS is a sane default,
platform code has to sanity check masks passed via set_affinity() calls
anyway. So I beleive it should be fixed in the platform code.

Max

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/