linux-kernel - [PATCH] mfd: Fix define values of CS1_HIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Nov 2008 20:24:35 +0900
From:	Naohiro Ooiwa <nooiwa@...aclelinux.com>
To:	broonie@...nsource.wolfsonmicro.com
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] mfd: Fix define values of CS1_HIB_MODE.

Hi Mark,

I found a little mistake.
The define values are wrong.

It is written in the WM8350 DATA SHEET Rev 3.4 P285 that
CS1_HIB_MODE(bit 12) is disable at "1".

The following is it.

<WM8350 DATA SHEET Rev 3.4   P285>

REGISTER |BIT|    LABEL   | DESCRIPTION
ADDRESS  |   |            |
---------+---+------------+-------------
R172(ACh)| 12|CS1_HIB_MODE| 0=leave current sink as in Active
         |   |            | 1=disable current shik in Hibemate

Could you please check the following patch ?

Regards,
Naohiro Ooiwa

Signed-off-by: Naohiro Ooiwa <nooiwa@...aclelinux.com>
---
 include/linux/mfd/wm8350/pmic.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mfd/wm8350/pmic.h b/include/linux/mfd/wm8350/pmic.h
index 656279a..078363b 100644
--- a/include/linux/mfd/wm8350/pmic.h
+++ b/include/linux/mfd/wm8350/pmic.h
@@ -83,8 +83,8 @@
 #define WM8350_CS1_ISEL_SHIFT                        0

 /* Bit values for R172 (0xAC) */
-#define WM8350_CS1_HIB_MODE_DISABLE                  0
-#define WM8350_CS1_HIB_MODE_LEAVE                    1
+#define WM8350_CS1_HIB_MODE_DISABLE                  1
+#define WM8350_CS1_HIB_MODE_LEAVE                    0

 #define WM8350_CS1_ISEL_220M                      0x3F

-- 
1.5.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/