linux-kernel - Re: [PATCH 2.6.28-rc5 05/11] kmemleak: Add support for i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081120121633.GG20724@elte.hu>
Date:	Thu, 20 Nov 2008 13:16:34 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.28-rc5 05/11] kmemleak: Add support for i386


* Catalin Marinas <catalin.marinas@....com> wrote:

> This patch adds the kmemleak-related entries to the vmlinux.lds.S
> linker script.
> 
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> ---
>  arch/x86/kernel/vmlinux_32.lds.S |    1 +

a small detail: a better changelog would be:

|   x86: provide _sdata
|
|   Impact: provide generic symbol
|
|   _sdata is a common symbol defined by many architectures and made
|   available to the core kernel via asm-generic/sections.h.
|
|   Add it to x86 too, so that kmemleak can make use of it.

it is more informative this way, and would be in the customary x86 
commit style.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/