linux-kernel - Re: [PATCH 30 of 38] xen: implement io_apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081120083329.GA13996@verge.net.au>
Date:	Thu, 20 Nov 2008 17:33:31 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Xen-devel <xen-devel@...ts.xensource.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Ian Campbell <ian.campbell@...rix.com>
Subject: Re: [PATCH 30 of 38] xen: implement io_apic_ops

Hi,

it seems that if CONFIG_XEN is set by CONFIG_XEN_DOM0 is not set,
then the call to xen_init_apic() in xen_start_kernel() causes the
build to fail.

One possible soluion to this is to provide a dummy
version of xen_init_apic() in the !CONFIG_XEN_DOM0 case.

Another possible solution would be to add #ifdef CONFIG_XEN_DOM0
inside xen_start_kernel()

#make gcc --version
gcc (Debian 4.3.2-1) 4.3.2
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

# make
[snip]
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/x86/xen/built-in.o: In function `xen_start_kernel':
(.init.text+0x8ef): undefined reference to `xen_init_apic'

Index: linux-2.6/arch/x86/xen/xen-ops.h
===================================================================
--- linux-2.6.orig/arch/x86/xen/xen-ops.h	2008-11-20 17:23:14.000000000 +0900
+++ linux-2.6/arch/x86/xen/xen-ops.h	2008-11-20 17:24:28.000000000 +0900
@@ -64,7 +64,11 @@ static inline void xen_smp_init(void) {}
 #endif
 
 
+#ifdef CONFIG_XEN_DOM0
 void xen_init_apic(void);
+#else
+static inline void xen_init_apic(void) { ; }
+#endif
 
 /* Declare an asm function, along with symbols needed to make it
    inlineable */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/