linux-kernel - Re: [PATCH] intel-iommu: make init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1227191861.4901.24.camel@macbook.infradead.org>
Date:	Thu, 20 Nov 2008 14:37:41 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	Mark McLoughlin <markmc@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] intel-iommu: make init_dmars() static

On Thu, 2008-11-20 at 14:24 +0000, Mark McLoughlin wrote:
> On Thu, 2008-11-20 at 14:21 +0000, Mark McLoughlin wrote:
> > init_dmars() is not used outside of drivers/pci/intel-iommu.c
> 
> Note, most of linux/dma_remapping.h is only needed by intel-iommu.c

Most.

> Any objections into moving all of that into intel-iommu.c?

That would seem to make sense. Don't forget to check IA64 when declaring
stuff unused though :)

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/