linux-kernel - Re: [PATCH] x86: fix wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4924E0C7.8000003@ct.jp.nec.com>
Date:	Wed, 19 Nov 2008 20:00:07 -0800
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2

Yinghai Lu wrote:
> Ingo Molnar wrote:
>> hm, one of my testboxes is rather unhappy about your patch:
> 
> 
> please check
> 
> if you agree, will update update_genapic to autodetect other functions or etc.
> 
> YH
> 
> ---
> 
> [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 - fix
> 
> Impact: fix wakeup_secondary_cpu with hotplug
> 
> We can not put that in x86_quirks, because that is __initdata.
> So try to move that to genapic, and add update_genapic in x86_quirks.
> 
> later we even could use that stub to
> 1. autodetect CONFIG_ES7000_CLUSTERED_APIC
> 2. more correct inquire_remote_apic with apic_verbosity setting.

Hi,

I encountered boot failure on x86_32 box.
I think setting wakeup_cpu is missing.

--------
From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Subject: [PATCH] x86: genapic: fix missing wakeup_cpu setup

Impact: fix boot failure

There is no way to setup wakeup_cpu when boot parameter apic= is not passed.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
---
 arch/x86/mach-generic/probe.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/x86/mach-generic/probe.c b/arch/x86/mach-generic/probe.c
index 90b134f..bde6e36 100644
--- a/arch/x86/mach-generic/probe.c
+++ b/arch/x86/mach-generic/probe.c
@@ -98,6 +98,9 @@ void __init generic_apic_probe(void)
 		/* Not visible without early console */
 		if (!apic_probe[i])
 			panic("Didn't find an APIC driver");
+
+		if (x86_quirks->update_genapic)
+			x86_quirks->update_genapic();
 	}
 	printk(KERN_INFO "Using APIC driver %s\n", genapic->name);
 }
-- 
1.5.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/