linux-kernel - Re: in 2.6.23-rc3-git7 in do_cciss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081120175029.GM26308@kernel.dk>
Date:	Thu, 20 Nov 2008 18:50:30 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	scsi <linux-scsi@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: in 2.6.23-rc3-git7 in do_cciss_intr

On Thu, Nov 20 2008, Miller, Mike (OS Dev) wrote:
> Jens wrote:
> 
> > >
> > > I'd propose just converting it to list_head instead of doing it
> > > manually. Heck, that should be a 5 minute job, let me just do it...
> > >
> > > OK, here it is, totally untested (it compiles, must be golden...)
> >
> > It was missing a list_entry() in fail_all_cmds(), apart from
> > that it was fine. I changed it to use hlist instead, as that
> > is more appropriate and similar to how it worked before. It
> > also means there's no extra space usage in the controller
> > structure. I've tested it and it works fine for me.
> >
> > Mike, can you give this a look-over and give me a Reviewed-by
> > or similar? As an extra bonus, it also gets rid of some code.
> >
> >  3 files changed, 33 insertions(+), 46 deletions(-)
> >
> > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e303054
> > e55acd1b6478b8859a5f8648bfaf69a44
> 
> That works for me. :)
> 
> Acked-by: Mike Miller <mike.miller@...com>

Excellent, thanks Mike. If you could run it through a cycle or so of
your regular testing, I'd feel 100% confident in it.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/