linux-kernel - Re: [PATCH] x86: fix wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4925A94E.4000806@ct.jp.nec.com>
Date:	Thu, 20 Nov 2008 10:15:42 -0800
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> wrote:
> 
>> Yinghai Lu wrote:
>>> Ingo Molnar wrote:
>>>> hm, one of my testboxes is rather unhappy about your patch:
>>>
>>> please check
>>>
>>> if you agree, will update update_genapic to autodetect other functions or etc.
>>>
>>> YH
>>>
>>> ---
>>>
>>> [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 - fix
>>>
>>> Impact: fix wakeup_secondary_cpu with hotplug
>>>
>>> We can not put that in x86_quirks, because that is __initdata.
>>> So try to move that to genapic, and add update_genapic in x86_quirks.
>>>
>>> later we even could use that stub to
>>> 1. autodetect CONFIG_ES7000_CLUSTERED_APIC
>>> 2. more correct inquire_remote_apic with apic_verbosity setting.
>> Hi,
>>
>> I encountered boot failure on x86_32 box.
>> I think setting wakeup_cpu is missing.
>>
>> --------
>> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>> Subject: [PATCH] x86: genapic: fix missing wakeup_cpu setup
>>
>> Impact: fix boot failure
>>
>> There is no way to setup wakeup_cpu when boot parameter apic= is not passed.
>>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>> ---
>>  arch/x86/mach-generic/probe.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> thanks - i've applied the wider fix from Yinghai - see it below.
> 
> i'm wondering why my tests didnt trigger this boot crash. What makes 
> your system or .config special to trigger it?

I attached the .config I'm using.

And here is panic log at the boot.

CPU: Trace cache: 12K uops, L1 D cache: 16K
CPU: L2 cache: 2048K
CPU: Physical Processor ID: 0
CPU: Processor Core ID: 0
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU0: Intel P4/Xeon Extended MCE MSRs (24) available
CPU0: Thermal monitoring enabled
using mwait in idle threads.
Checking 'hlt' instruction... OK.
ACPI: Core revision 20080926
..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
CPU0: Intel(R) Xeon(TM) CPU 3.80GHz stepping 0a
Booting processor 1 APIC 0x6 ip 0x6000
invalid opcode: 0000 [#1] PREEMPT SMP 
last sysfs file: 
Modules linked in:

Pid: 1, comm: swapper Not tainted (2.6.28-rc5-tip-00857-g5c47ccc #250) Express5800/120Rf-1 [N8100-1099]        
EIP: 0060:[<00000003>] EFLAGS: 00010282 CPU: 0
EIP is at 0x3
EAX: 00000006 EBX: 00006000 ECX: c045d8c0 EDX: 00006000
ESI: 00000001 EDI: f7423f8c EBP: f7423fa8 ESP: f7423f50
 DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
Process swapper (pid: 1, ti=f7422000 task=f7430000 task.ti=f7422000)
Stack:
 00006000 c03482a6 00000000 f7423f64 00000006 00000000 f7423f68 f7423f68
 c0347d10 f7436080 00000001 00000101 f7423f80 f7423f80 00000001 00000000
 00000000 f7423f80 f7423f80 00000001 00000000 f7423fb0 f7423fc0 c0349309
Call Trace:
 [<c03482a6>] ? native_cpu_up+0x26e/0x3b3
 [<c0347d10>] ? do_fork_idle+0x0/0x1e
 [<c0349309>] ? _cpu_up+0x88/0xea
 [<c03493af>] ? cpu_up+0x44/0x54
 [<c04c34bc>] ? kernel_init+0x94/0x141
 [<c04c3428>] ? kernel_init+0x0/0x141
 [<c010398b>] ? kernel_thread_helper+0x7/0x10
Code:  Bad EIP value.
EIP: [<00000003>] 0x3 SS:ESP 0068:f7423f50
---[ end trace 4eaa2a86a8e2da22 ]---
Kernel panic - not syncing: Attempted to kill init!

thanks,
Hiroshi Shimamoto

View attachment "tip32.config" of type "text/plain" (39594 bytes)