linux-kernel - Re: mm: slab - __cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Nov 2008 22:03:37 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Valdis.Kletnieks@...edu
CC:	Cyrill Gorcunov <gorcunov@...il.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: mm: slab - __cache_alloc NULL prefetch fix

Valdis.Kletnieks@...edu wrote:
> On Thu, 20 Nov 2008 19:44:00 +0300, Cyrill Gorcunov said:
> 
>> -	prefetchw(objp);
>>  
>> -	if (likely(objp))
>> +	if (likely(objp)) {
>> +		prefetchw(objp);
>>  		kmemcheck_slab_alloc(cachep, flags, objp, obj_size(cachep));
>> +	}
> 
> Although it probably makes sense to not bother prefetching NULL, I also
> need to wonder how useful it is to prefetch something that we then
> turn around and dereference in the very next line of code.

Note that kmemcheck_slab_alloc() is going to be a no-op on anything but 
a special developer or tester debug config.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/