linux-kernel - Re: [PATCH] x86: powernow-k8: ignore out-of-range PstateStatus value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081121151252.GA17052@elte.hu>
Date:	Fri, 21 Nov 2008 16:12:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andreas Herrmann <andreas.herrmann3@....com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	cpufreq@...r.kernel.org, stable@...nel.org,
	"Langsdorf, Mark" <mark.langsdorf@....com>,
	linux-kernel@...r.kernel.org, davej@...hat.com
Subject: Re: [PATCH] x86: powernow-k8: ignore out-of-range PstateStatus
	value


* Andreas Herrmann <andreas.herrmann3@....com> wrote:

> On Fri, Nov 21, 2008 at 09:23:46AM +0100, Ingo Molnar wrote:
> > 
> > nice fix! A few minor nits:
> > 
> > > +			/* a workaround for family 11h erratum 311 might cause
> > > +			   an "out-of-range Pstate if the core is in Pstate-0 */
> 
> > Please use the customary comment style:
> >   /*
> >    * Comment .....
> >    * ...... goes here:
> >    */
> 
> I don't prefer that style -- but if you do.

it's not about my or your preference. It's about what we all do in the 
kernel, documented in Documentation/CodingStyle:

| The preferred style for long (multi-line) comments is:
|
|        /*
|         * This is the preferred style for multi-line
|         * comments in the Linux kernel source code.
|         * Please use it consistently.
|         *
|         * Description:  A column of asterisks on the left side,
|         * with beginning and ending almost-blank lines.
|         */


	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/