linux-kernel - Re: [PATCH 24/45] CacheFiles: Add a hook to write a single page of data to an inode [ver #41]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12060.1227287735@turing-police.cc.vt.edu>
Date:	Fri, 21 Nov 2008 12:15:35 -0500
From:	Valdis.Kletnieks@...edu
To:	Jamie Lokier <jamie@...reable.org>
Cc:	David Howells <dhowells@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	trond.myklebust@....uio.no, viro@...IV.linux.org.uk,
	nfsv4@...ux-nfs.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: [PATCH 24/45] CacheFiles: Add a hook to write a single page of data to an inode [ver #41]

On Fri, 21 Nov 2008 13:00:30 GMT, Jamie Lokier said:
> Couldn't we just skip the "wasted" comment lines and go to //-style
> comments, since it's been standard GCC for what, 13 years now?  And
> standard ANSI C for some 9 years...

The problem is that // style comments tend to encourage *really* short
comments, because we're already hitting col 80:

	current->whizbang = some_random_func(dev->wombats, 0); //vryshrtcmmnt

Making people use block comments encourages this:

	/*
	 * Since we're committed to at least 3 lines anyhow, take an
	 * extra line or two and explain why we're checking dev->wombats,
	 * rather than the more obvious proto->giraffe field....
	 */
	current->whizbang = some_random_func(dev->wombats, 0);

(And before you ask, trying to ban // comments on the right-hand of code, and
using // for block comments rather than /*... */ is the worst of both worlds.


Content of type "application/pgp-signature" skipped