linux-kernel - RE: [PATCH] x86: Fix interrupt leak due to migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A0EC28107@orsmsx507.amr.corp.intel.com>
Date:	Fri, 21 Nov 2008 10:31:59 -0800
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	Matthew Wilcox <matthew@....cx>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...l.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Yinghai Lu <yhlu.kernel@...il.com>
Subject: RE: [PATCH] x86: Fix interrupt leak due to migration

Matthew Wilcox wrote:
> When we migrate an interrupt from one CPU to another, we set the
> move_in_progress flag and clean up the vectors later once they're not
> being used.  If you're unlucky and call destroy_irq() before the
> vectors become un-used, the move_in_progress flag is never cleared,
> which causes the interrupt to become unusable.
> 
> This was discovered by Jesse Brandeburg for whom it manifested as an
> MSI-X device refusing to use MSI-X mode when the driver was unloaded
> and reloaded repeatedly.
> 
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>

We did some other quick testing on this and it seems good.  Thanks 
and good work Matthew!

Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/