[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081121111414.GA1455@elf.ucw.cz>
Date: Fri, 21 Nov 2008 12:14:14 +0100
From: Pavel Machek <pavel@...e.cz>
To: rpurdie@...ys.net, kernel list <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...l.org>
Subject: backlight: catch invalid input
Currently, echo > brightness turns brightness to zero due to
insufficient checking. Add a test to catch that.
Signed-off-by: Pavel Machek <pavel@...e.cz>
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index fab0bc8..5c2e23d 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -86,6 +86,8 @@ static ssize_t backlight_store_power(str
int power = simple_strtoul(buf, &endp, 0);
size_t size = endp - buf;
+ if (!size)
+ return -EINVAL;
if (*endp && isspace(*endp))
size++;
if (size != count)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists