[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081121080610.GG16242@elte.hu>
Date: Fri, 21 Nov 2008 09:06:11 +0100
From: Ingo Molnar <mingo@...e.hu>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Dimitri Sivanich <sivanich@....com>,
Thomas Gleixner <tglx@...utronix.de>,
linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver and
generic timer vector
* H. Peter Anvin <hpa@...or.com> wrote:
> Ingo Molnar wrote:
> > * Dimitri Sivanich <sivanich@....com> wrote:
> >
> >> The following patches provide a driver for synchronized RTC
> >> clocksource and clockevents for SGI systems, as well as a generic
> >> timer system interrupt.
> >>
> >> With these patches, a module can be installed that registers the
> >> system-wide synchronized RTC clocksource and timers as both a
> >> clocksource and clockevents device running in high resolution mode.
> >>
> >> [PATCH 1/2 v3] SGI RTC: add clocksource driver
> >> [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt
> >
> > Looks very clean and well-done to me.
> >
> > I had to take a good look at the rtc_timer_head->expires[] construct -
> > but i guess that's the best approach, as the max number of entries is
> > hard to judge at build time. (and we wont get any real limit
> > protection from gcc anyway)
> >
> > Thomas, any objections?
>
> I have *extremely* serious reservations about reserving even more
> hardware vectors for SGI only. This affects all systems, and quite
> frankly should not be necessary at all.
>
> The SGI UV people have pushed this at a number of points in the
> past, and we have told them to use an irqchip instead. This patch
> tries to allocate yet another reserved vector, instead.
ah, yes, i suggested that in the past. And i was _so_ happy that this
driver wasnt calling into the BIOS anymore but talking straight to the
hardware ;-)
it shouldnt be hard to define a proper irqchip here.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists