linux-kernel - Re: [PATCH] amd74xx: workaround unreliable AltStatus register for nVidia controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081122113342.GA8593@gollum.tnic>
Date:	Sat, 22 Nov 2008 12:33:42 +0100
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Remy LABENE <remy.labene@...e.fr>
Subject: Re: [PATCH] amd74xx: workaround unreliable AltStatus register for
	nVidia controllers

On Fri, Nov 21, 2008 at 10:38:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
> It seems that on some nVidia controllers using AltStatus register
> can be unreliable so default to Status register if the PCI device
> is in Compatibility Mode.  In order to achieve this:
> 
> * Add ide_pci_is_in_compatibility_mode() inline helper to <linux/ide.h>.
> 
> * Add IDE_HFLAG_BROKEN_ALTSTATUS host flag and set it in amd74xx host
>   driver for nVidia controllers in Compatibility Mode.
> 
> * Teach actual_try_to_identify() and drive_is_ready() about the new flag.
> 
> This fixes the regression caused by removal of CONFIG_IDEPCI_SHARE_IRQ
> config option in 2.6.25 and using AltStatus register unconditionally when
> available (kernel.org bug #11659).  [ Moreover for CONFIG_IDEPCI_SHARE_IRQ=y
> (which is what most distributions/people use) it never worked correctly. ]

Looks good.

Acked-by: Borislav Petkov <petkovbb@...il.com>

> 
> Thanks to Remy LABENE for help with debugging the problem.
> 
> More info at:
> http://bugzilla.kernel.org/show_bug.cgi?id=11659

Bugzilla entry can be closed now.

[.. ]

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/