linux-kernel - Re: [PATCH 1/3] driver/net/*: remove redundant argument comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081122114014.379f2762@lxorguk.ukuu.org.uk>
Date:	Sat, 22 Nov 2008 11:40:14 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
Cc:	"Qinghuang Feng" <qhfeng.kernel@...il.com>,
	"David Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] driver/net/*: remove redundant argument comments

> > - * @rx_ring: pointer to receive ring structure
> >  * @cleaned_count: number of buffers to allocate this pass
> >  **/
> >
> 
> NAK - rather than removing documentation, I would suggest improving
> the documentation.  

I would suggest reading the patch more carefully - there is no rx_ring
argument. The documentation in the header is stale.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/