[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1227373948.19591.66.camel@brutus>
Date: Sat, 22 Nov 2008 15:12:28 -0200
From: Daniel Ribeiro <drwyrm@...il.com>
To: David Brownell <david-b@...bell.net>
Cc: spi-devel-general@...ts.sourceforge.net, stefan@...enfreihafen.org,
eric.y.miao@...il.com, sameo@...nedhand.com,
linux-arm-kernel@...ts.arm.linux.org.uk,
linux-kernel@...r.kernel.org
Subject: Re: [spi-devel-general] [patch 05/14] mfd: PCAP2 driver
Em Sex, 2008-11-21 às 21:25 -0800, David Brownell escreveu:
> I took a quick glance at this and it seemed like it should be
> able to build without depending on PXA ... should certainly
> not include <mach/ssp.h> or <mach/regs-ssp.h>, and it doesn't
> look like it needs PXA-specific stuff like <mach/mfp-pxa27x.h>
> either.
>
> It's also worth removing the reverse dependencies ("select X")
> from Kconfig; they don't work very well for the things which
> those dependencies rely on.
Above comments are integrated on the attached patch.
--
Daniel Ribeiro
Download attachment "pcap.diff" of type "message/rfc822" (26516 bytes)
Powered by blists - more mailing lists