linux-kernel - Re: [PATCH 2/3] proc: Export statistics for softirq to /proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081121173518.5ffe3a9e.akpm@linux-foundation.org>
Date:	Fri, 21 Nov 2008 17:35:18 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Keika Kobayashi <kobayashi.kk@...s.nec.co.jp>
Cc:	linux-kernel@...r.kernel.org, h-shimamoto@...jp.nec.com,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH 2/3] proc: Export statistics for softirq to /proc

On Fri, 21 Nov 2008 17:07:43 -0800 Keika Kobayashi <kobayashi.kk@...s.nec.co.jp> wrote:

> > This uses for_each_online_cpu(), but below we use for_each_possible_cpu().
> > 
> > Shouldn't we be consistent here so that at least the numbers will add
> > up to the same thing?
> > 
> > Probably for_each_possible_cpu() is best - people might want to see how
> > many softirqs happened on a CPU which was recently offlined.
> 
> I understand this point. I'll fix it later.
> 
> There is same problem regarding /proc/interrupts.
> Should we change from for_each_online_cpu() to for_each_possible_cpu(),
> or is it too late?

I assume that /proc/interrupts has been that way for a very long time,
and nobody has noticed&complained.  If we can find anyone who actually
uses cpu hotplug then perhaps they could help us out here.  But such
people seem to be rare.

I dunno.  I guess we can leave /proc/interrupts alone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/