linux-kernel - Re: [PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081123132752.GF1178@elte.hu>
Date:	Sun, 23 Nov 2008 14:27:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexander van Heukelum <heukelum@...lshack.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jan Beulich <jbeulich@...ell.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Cyrill Gorcunov <gorcunov@...il.com>
Subject: Re: [PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE_END


* Alexander van Heukelum <heukelum@...lshack.com> wrote:

> Impact: moves some code out of .kprobes.text
> 
> KPROBE_ENTRY switches code generation to .kprobes.text, and KPROBE_END
> uses .popsection to get back to the previous section (.text, normally).
> Also replace ENDPROC by END, for consistency.
> 
> Signed-off-by: Alexander van Heukelum <heukelum@...tmail.fm>

applied to tip/x86/irq, thanks Alexander!

> One more small change for today. The xen-related functions 
> xen_do_hypervisor_callback and xen_failsafe_callback are put
> in the .kprobes.text even in the current kernel: ignore_sysret
> is enclosed in KPROBE_ENTRY / ENDPROC, instead of KPROBE_ENTRY /
> KPROBE_END, but I guess the situation is harmless.

yeah. It narrows no-kprobes protection for that code, but it should 
indeed be fine (and that's the intention as well).

Note that this is a reoccuring bug type, and rather long-lived. Can 
you think of any way to get automated nesting protection of both the 
.cfi_startproc/endproc macros and kprobes start/end? A poor man's 
solution would be to grep the number of start and end methods and 
enforce that they are equal.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/