linux-kernel - Re: [PATCH 4/4] trace: profile all if conditionals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081123154830.GA24412@elte.hu>
Date:	Sun, 23 Nov 2008 16:48:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Theodore Tso <tytso@....edu>,
	Arjan van de Ven <arjan@...radead.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 4/4] trace: profile all if conditionals


* Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <srostedt@...hat.com>
> 
> Impact: feature to profile if statements
> 
> This patch adds a branch profiler for all if () statements.
> The results will be found in:
> 
>   /debugfs/tracing/profile_branch
> 
> For example:
> 
>    miss      hit    %        Function                  File              Line
>  ------- ---------  -        --------                  ----              ----
>        0        1 100 x86_64_start_reservations      head64.c             127
>        0        1 100 copy_bootdata                  head64.c             69
>        1        0   0 x86_64_start_kernel            head64.c             111
>       32        0   0 set_intr_gate                  desc.h               319
>        1        0   0 reserve_ebda_region            head.c               51
>        1        0   0 reserve_ebda_region            head.c               47
>        0        1 100 reserve_ebda_region            head.c               42
>        0        0   X maxcpus                        main.c               165

-tip testing found this build failure:

 net/wireless/reg.c:348:29: error: macro "if" passed 2 arguments, but takes just 1

with the attached config. Seems the macro confused some aspect of WARN() 
?

	Ingo

View attachment "config" of type "text/plain" (68644 bytes)