linux-kernel - Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081123194828.GQ12710@localhost>
Date:	Sun, 23 Nov 2008 22:48:28 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	Alexander van Heukelum <heukelum@...lshack.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86  assembly helpers
	to catch unbalanced declaration

[Ingo Molnar - Sun, Nov 23, 2008 at 08:31:34PM +0100]
...
| > 
| > Just got an error in implementation -- we have to support nested
| > ENTRY without problem. Will check. What a surprise :-)
| 
| do you mean:
| 
|   ENTRY(system_call)
|   ENTRY(system_call_after_swapgs)
|   ...
|   END(system_call)
| 
| that's more of a bug - system_call_after_swapgs is not a real entry 
| point, we just need the label of it. Perhaps something like __ENTRY() 
| for that case would be enough.
| 
| nor is this one real:
| 
|   ENTRY(interrupt)
|   ENTRY(irq_entries_start)
|   ...
|   END(irq_entries_start)
|   END(interrupt)
| 
| do we really need .irq_entries_start?
| 
| I think in general we should define a flat hierarchy of entries.
| 
| 	Ingo
| 

Yeah, I meant these cases. I don't think we really need irq_entries_start
(didn't find any mention of them in tree). In case of system_call_after_swapgs
I'm not that sure, but since xen use it as a plain jmp (at least now) it
could be converted to a plain label. Ingo, I'll continue tomorrow evening --
have some other things to be done :)

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/